lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 8 Dec 2020 12:51:55 -0700
From:   David Ahern <>
To:     Andrea Mayer <>,
        "David S. Miller" <>,
        David Ahern <>,
        Jakub Kicinski <>,
        Shrijeet Mukherjee <>,,
Cc:     Stefano Salsano <>,
        Paolo Lungaroni <>,
        Ahmed Abdelsalam <>,
        kernel test robot <>
Subject: Re: [PATCH net-next] vrf: handle CONFIG_IPV6 not set for

On 12/8/20 10:52 AM, Andrea Mayer wrote:
> The vrf_add_mac_header_if_unset() is defined within a conditional
> compilation block which depends on the CONFIG_IPV6 macro.
> However, the vrf_add_mac_header_if_unset() needs to be called also by IPv4
> related code and when the CONFIG_IPV6 is not set, this function is missing.
> As a consequence, the build process stops reporting the error:
>  ERROR: implicit declaration of function 'vrf_add_mac_header_if_unset'
> The problem is solved by *only* moving functions
> vrf_add_mac_header_if_unset() and vrf_prepare_mac_header() out of the
> conditional block.
> Reported-by: kernel test robot <>
> Fixes: 0489390882202 ("vrf: add mac header for tunneled packets when sniffer is attached")
> Signed-off-by: Andrea Mayer <>
> ---
>  drivers/net/vrf.c | 110 +++++++++++++++++++++++-----------------------
>  1 file changed, 55 insertions(+), 55 deletions(-)

I should have caught that in my review.

Reviewed-by: David Ahern <>

Powered by blists - more mailing lists