netdev - Re: [PATCH net-next] vrf: handle CONFIG_IPV6 not set for vrf_add_mac_header_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201209120432.08ad638b@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Wed, 9 Dec 2020 12:04:32 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...il.com>,
        Andrea Mayer <andrea.mayer@...roma2.it>
Cc:     "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Shrijeet Mukherjee <shrijeet@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stefano Salsano <stefano.salsano@...roma2.it>,
        Paolo Lungaroni <paolo.lungaroni@...t.it>,
        Ahmed Abdelsalam <ahabdels.dev@...il.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] vrf: handle CONFIG_IPV6 not set for
 vrf_add_mac_header_if_unset()

On Tue, 8 Dec 2020 12:51:55 -0700 David Ahern wrote:
> On 12/8/20 10:52 AM, Andrea Mayer wrote:
> > The vrf_add_mac_header_if_unset() is defined within a conditional
> > compilation block which depends on the CONFIG_IPV6 macro.
> > However, the vrf_add_mac_header_if_unset() needs to be called also by IPv4
> > related code and when the CONFIG_IPV6 is not set, this function is missing.
> > As a consequence, the build process stops reporting the error:
> > 
> >  ERROR: implicit declaration of function 'vrf_add_mac_header_if_unset'
> > 
> > The problem is solved by *only* moving functions
> > vrf_add_mac_header_if_unset() and vrf_prepare_mac_header() out of the
> > conditional block.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Fixes: 0489390882202 ("vrf: add mac header for tunneled packets when sniffer is attached")
> > Signed-off-by: Andrea Mayer <andrea.mayer@...roma2.it>
>
> I should have caught that in my review.
> 
> Reviewed-by: David Ahern <dsahern@...nel.org>

Applied, thank you!