netdev - Re: [PATCH net v2] net/tls: Fix kernel panic when socket is in tls toe mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201208125457.05b6f323@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Tue, 8 Dec 2020 12:54:57 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vinay Kumar Yadav <vinay.yadav@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com,
        Rohit Maheshwari <rohitm@...lsio.com>
Subject: Re: [PATCH net v2] net/tls: Fix kernel panic when socket is in tls
 toe mode

On Wed, 9 Dec 2020 00:46:23 +0530 Vinay Kumar Yadav wrote:
> On 12/8/2020 11:49 PM, Jakub Kicinski wrote:
> > On Sat,  5 Dec 2020 17:05:30 +0530 Vinay Kumar Yadav wrote:  
> >> When socket is in tls-toe (TLS_HW_RECORD) and connections
> >> are established in kernel stack, on every connection close
> >> it clears tls context which is created once on socket creation,
> >> causing kernel panic. fix it by not initializing listen in
> >> kernel stack incase of tls-toe, allow listen in only adapter.  
> > 
> > IOW the socket will no longer be present in kernel's hash tables?
>
> Yes, when tls-toe devices are present.

I don't think that's acceptable for a transparently enabled
netdev-sanctioned feature.