netdev - Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of cpu node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Dec 2020 13:42:06 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        David S Miller <davem@...emloft.net>,
        Helmut Grohne <helmut.grohne@...enta.de>,
        netdev <netdev@...r.kernel.org>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>
Subject: Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of
 cpu node

On Tue, Dec 8, 2020 at 11:52 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> What I was talking about in the email yesterday was 0x8794 support
> in ksz8795.c. Is the cpu port configuration going to work there?
> Isn't the CPU port always port 5 (index 4)?

Understood. You expressed concern that .cpu_ports = 0x10 even on the 3-port
switch.

I noticed that .cpu_ports is never used in ksz8794.c, so I hoped the fix
would be fine. But digging a bit deeper, I see in ksz8795.c:

        dev->mib_port_cnt = TOTAL_PORT_NUM; /* = 5 */
        ...
        dev->cpu_port = dev->mib_port_cnt - 1; /* = 4 */

And that is unlikely to work on the 3-port switch.
So yeah, you are right, my patch won't fix the general issues here :(