netdev - Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of cpu node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201208085216.790ecdc3@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Tue, 8 Dec 2020 08:52:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        David S Miller <davem@...emloft.net>,
        Helmut Grohne <helmut.grohne@...enta.de>,
        netdev <netdev@...r.kernel.org>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>
Subject: Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing
 of cpu node

On Tue, 8 Dec 2020 10:33:28 -0500 Sven Van Asbroeck wrote:
> Andrew, Jakub,
> 
> On Sat, Dec 5, 2020 at 10:28 AM Sven Van Asbroeck <thesven73@...il.com> wrote:
> >
> > From: Sven Van Asbroeck <thesven73@...il.com>
> >
> > On the ksz8795, if the devicetree contains a cpu node,
> > devicetree parsing fails and the whole driver errors out.
> >
> > Fix the devicetree parsing code by making it use the
> > correct number of ports.
> >
> > Fixes: 912aae27c6af ("net: dsa: microchip: really look for phy-mode in port nodes")
> > Tested-by: Sven Van Asbroeck <thesven73@...il.com> # ksz8795
> > Signed-off-by: Sven Van Asbroeck <thesven73@...il.com>
> > ---  
> 
> Any chance that this patch could still get merged?
> I believe this will work fine on both ksz8795 and ksz9477, even though num_ports
> is defined differently, because:
> 
> ksz8795:
> /* set the real number of ports */
> dev->ds->num_ports = dev->port_cnt + 1;
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/dsa/microchip/ksz8795.c?h=v5.10-rc7#n1266
> 
> ksz9477:
> /* set the real number of ports */
> dev->ds->num_ports = dev->port_cnt;
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/dsa/microchip/ksz9477.c?h=v5.10-rc7#n1585
> 
> Would it be possible to merge this into net, so users get working cpu nodes?
> I don't think this will prevent you from harmonizing port_cnt in net-next.

What I was talking about in the email yesterday was 0x8794 support
in ksz8795.c. Is the cpu port configuration going to work there?
Isn't the CPU port always port 5 (index 4)?

It sure as hell looked like it until commit c9f4633b93ea ("net: dsa:
microchip: remove usage of mib_port_count") came along. I wonder if 
ksz8794 works on net-next :/