lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 8 Dec 2020 10:33:28 -0500
From:   Sven Van Asbroeck <>
To:     Woojung Huh <>,
        Microchip Linux Driver Support <>,
        Andrew Lunn <>,
        Vivien Didelot <>,
        Florian Fainelli <>,
        Vladimir Oltean <>,
        David S Miller <>,
        Jakub Kicinski <>
Cc:     Helmut Grohne <>,
        netdev <>,
        Linux Kernel Mailing List <>
Subject: Re: [PATCH net v1 1/2] net: dsa: microchip: fix devicetree parsing of
 cpu node

Andrew, Jakub,

On Sat, Dec 5, 2020 at 10:28 AM Sven Van Asbroeck <> wrote:
> From: Sven Van Asbroeck <>
> On the ksz8795, if the devicetree contains a cpu node,
> devicetree parsing fails and the whole driver errors out.
> Fix the devicetree parsing code by making it use the
> correct number of ports.
> Fixes: 912aae27c6af ("net: dsa: microchip: really look for phy-mode in port nodes")
> Tested-by: Sven Van Asbroeck <> # ksz8795
> Signed-off-by: Sven Van Asbroeck <>
> ---

Any chance that this patch could still get merged?
I believe this will work fine on both ksz8795 and ksz9477, even though num_ports
is defined differently, because:

/* set the real number of ports */
dev->ds->num_ports = dev->port_cnt + 1;

/* set the real number of ports */
dev->ds->num_ports = dev->port_cnt;

Would it be possible to merge this into net, so users get working cpu nodes?
I don't think this will prevent you from harmonizing port_cnt in net-next.

Powered by blists - more mailing lists