netdev - Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207182832.346e246e@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Mon, 7 Dec 2020 18:28:32 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Chris Mi <cmi@...dia.com>
Cc:     netdev@...r.kernel.org, roid@...dia.com
Subject: Re: [PATCH net] net: flow_offload: Fix memory leak for indirect
 flow block

On Mon,  7 Dec 2020 09:59:16 +0800 Chris Mi wrote:
> The offending commit introduces a cleanup callback that is invoked
> when the driver module is removed to clean up the tunnel device
> flow block. But it returns on the first iteration of the for loop.
> The remaining indirect flow blocks will never be freed.
> 
> Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
> Signed-off-by: Chris Mi <cmi@...dia.com>
> Reviewed-by: Roi Dayan <roid@...dia.com>

Please repost and CC relevant people.