netdev - Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54ce3946-7b8b-1cb6-e949-f6854c6cd78c@nvidia.com>
Date:   Tue, 8 Dec 2020 10:49:27 +0800
From:   Chris Mi <cmi@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <roid@...dia.com>
Subject: Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow
 block

On 12/8/2020 10:28 AM, Jakub Kicinski wrote:
> On Mon,  7 Dec 2020 09:59:16 +0800 Chris Mi wrote:
>> The offending commit introduces a cleanup callback that is invoked
>> when the driver module is removed to clean up the tunnel device
>> flow block. But it returns on the first iteration of the for loop.
>> The remaining indirect flow blocks will never be freed.
>>
>> Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
>> Signed-off-by: Chris Mi <cmi@...dia.com>
>> Reviewed-by: Roi Dayan <roid@...dia.com>
> Please repost and CC relevant people.
>
Done.