lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Dec 2020 16:22:26 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Andrew Lunn <andrew@...n.ch> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>, davem@...emloft.net, robh+dt@...nel.org, nicolas.ferre@...rochip.com, linux@...linux.org.uk, paul.walmsley@...ive.com, palmer@...belt.com, yash.shah@...ive.com, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org Subject: Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks On Tue, 8 Dec 2020 19:48:56 +0100 Andrew Lunn wrote: > > -err_disable_rxclk: > > - clk_disable_unprepare(*rx_clk); > > - > > -err_disable_txclk: > > - clk_disable_unprepare(*tx_clk); > > - > > -err_disable_hclk: > > - clk_disable_unprepare(*hclk); > > - > > -err_disable_pclk: > > - clk_disable_unprepare(*pclk); > > +err_disable_clks: > > + macb_clks_disable(*pclk, *hclk, *tx_clk, *rx_clk, NULL); > > Personal taste, but i would of not changed this. +1 FWIW
Powered by blists - more mailing lists