lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Dec 2020 16:40:39 +0100 From: Daniel Borkmann <daniel@...earbox.net> To: Toke Høiland-Jørgensen <toke@...hat.com>, Jakub Kicinski <kuba@...nel.org> Cc: "David S. Miller" <davem@...emloft.net>, Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andriin@...com>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, Jesper Dangaard Brouer <hawk@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>, Romain Perier <romain.perier@...il.com>, Allen Pais <apais@...ux.microsoft.com>, Grygorii Strashko <grygorii.strashko@...com>, Simon Horman <simon.horman@...ronome.com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Lorenzo Bianconi <lorenzo@...nel.org>, Wei Yongjun <weiyongjun1@...wei.com>, Jiri Benc <jbenc@...hat.com>, oss-drivers@...ronome.com, linux-omap@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org Subject: Re: [PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order On 12/9/20 2:57 PM, Toke Høiland-Jørgensen wrote: > This series restores the test_offload.py selftest to working order. It seems a > number of subtle behavioural changes have crept into various subsystems which > broke test_offload.py in a number of ways. Most of these are fairly benign > changes where small adjustments to the test script seems to be the best fix, but > one is an actual kernel bug that I've observed in the wild caused by a bad > interaction between xdp_attachment_flags_ok() and the rework of XDP program > handling in the core netdev code. > > Patch 1 fixes the bug by removing xdp_attachment_flags_ok(), and the reminder of > the patches are adjustments to test_offload.py, including a new feature for > netdevsim to force a BPF verification fail. Please see the individual patches > for details. > > Changelog: > > v4: > - Accidentally truncated the Fixes: hashes in patches 3/4 to 11 chars > v3: > - Add Fixes: tags > v2: > - Replace xdp_attachment_flags_ok() with a check in dev_xdp_attach() > - Better packing of struct nsim_dev Applied, thanks! I took the liberty to document the prior review with 'LGTM' as an Ack so it's documented in the git log as well.
Powered by blists - more mailing lists