lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 09 Dec 2020 17:35:17 +0100
From:   Toke Høiland-Jørgensen <>
To:     Daniel Borkmann <>,
        Jakub Kicinski <>
Cc:     "David S. Miller" <>,
        Alexei Starovoitov <>,
        Andrii Nakryiko <>,
        Martin KaFai Lau <>,
        Song Liu <>, Yonghong Song <>,
        John Fastabend <>,
        KP Singh <>,
        Jesper Dangaard Brouer <>,
        "Michael S. Tsirkin" <>,
        Romain Perier <>,
        Allen Pais <>,
        Grygorii Strashko <>,
        Simon Horman <>,
        "Gustavo A. R. Silva" <>,
        Lorenzo Bianconi <>,
        Wei Yongjun <>,
        Jiri Benc <>,,,,
Subject: Re: [PATCH bpf v4 0/7] selftests/bpf: Restore to
 working order

Daniel Borkmann <> writes:

> On 12/9/20 2:57 PM, Toke Høiland-Jørgensen wrote:
>> This series restores the selftest to working order. It seems a
>> number of subtle behavioural changes have crept into various subsystems which
>> broke in a number of ways. Most of these are fairly benign
>> changes where small adjustments to the test script seems to be the best fix, but
>> one is an actual kernel bug that I've observed in the wild caused by a bad
>> interaction between xdp_attachment_flags_ok() and the rework of XDP program
>> handling in the core netdev code.
>> Patch 1 fixes the bug by removing xdp_attachment_flags_ok(), and the reminder of
>> the patches are adjustments to, including a new feature for
>> netdevsim to force a BPF verification fail. Please see the individual patches
>> for details.
>> Changelog:
>> v4:
>> - Accidentally truncated the Fixes: hashes in patches 3/4 to 11 chars
>> v3:
>> - Add Fixes: tags
>> v2:
>> - Replace xdp_attachment_flags_ok() with a check in dev_xdp_attach()
>> - Better packing of struct nsim_dev
> Applied, thanks! I took the liberty to document the prior review with 'LGTM' as
> an Ack so it's documented in the git log as well.

SGTM, thanks! :)


Powered by blists - more mailing lists