netdev - Re: [Patch bpf-next 0/3] bpf: introduce timeout map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzY_497=xXkfok4WFsMRRrC94Q6WwdUWZA_HezXaTtb5GQ@mail.gmail.com>
Date:   Fri, 11 Dec 2020 11:55:36 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch bpf-next 0/3] bpf: introduce timeout map

On Fri, Dec 11, 2020 at 2:28 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> From: Cong Wang <cong.wang@...edance.com>
>
> This patchset introduces a new bpf hash map which has timeout.
> Patch 1 is a preparation, patch 2 is the implementation of timeout
> map, patch 3 contains a test case for timeout map. Please check each
> patch description for more details.
>
> ---

This patch set seems to be breaking existing selftests. Please take a
look ([0]).
Also patch #3 should have a commit message, even if pretty trivial one.

  [0] https://travis-ci.com/github/kernel-patches/bpf/builds/207928289

> Cong Wang (3):
>   bpf: use index instead of hash for map_locked[]
>   bpf: introduce timeout map
>   tools: add a test case for bpf timeout map
>
>  include/linux/bpf_types.h               |   1 +
>  include/uapi/linux/bpf.h                |   3 +-
>  kernel/bpf/hashtab.c                    | 296 +++++++++++++++++++++---
>  kernel/bpf/syscall.c                    |   3 +-
>  tools/include/uapi/linux/bpf.h          |   1 +
>  tools/testing/selftests/bpf/test_maps.c |  41 ++++
>  6 files changed, 314 insertions(+), 31 deletions(-)
>
> --
> 2.25.1
>