lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 12 Dec 2020 19:43:10 -0800
From:   Florian Fainelli <>
To:     Vladimir Oltean <>,
        Andrew Lunn <>,
        Vivien Didelot <>,
        Jakub Kicinski <>,,,,
        Roopa Prabhu <>,
        Nikolay Aleksandrov <>,
        "David S. Miller" <>
Cc:     DENG Qingfang <>,
        Tobias Waldekranz <>,
        Marek Behun <>,
        Russell King - ARM Linux admin <>,
        Alexandra Winter <>,
        Jiri Pirko <>,
        Ido Schimmel <>,
        Claudiu Manoil <>
Subject: Re: [PATCH v2 net-next 2/6] net: dsa: don't use
 switchdev_notifier_fdb_info in dsa_switchdev_event_work

On 12/12/2020 6:40 PM, Vladimir Oltean wrote:
> Currently DSA doesn't add FDB entries on the CPU port, because it only
> does so through switchdev, which is associated with a net_device, and
> there are none of those for the CPU port.
> But actually FDB addresses on the CPU port have some use cases of their
> own, if the switchdev operations are initiated from within the DSA
> layer. There is just one problem with the existing code: it passes a
> structure in dsa_switchdev_event_work which was retrieved directly from
> switchdev, so it contains a net_device. We need to generalize the
> contents to something that covers the CPU port as well: the "ds, port"
> tuple is fine for that.
> Note that the new procedure for notifying the successful FDB offload is
> inspired from the rocker model.
> Also, nothing was being done if added_by_user was false. Let's check for
> that a lot earlier, and don't actually bother to schedule the worker
> for nothing.
> Signed-off-by: Vladimir Oltean <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists