[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201213172052.12433-1-vincent.stehle@laposte.net>
Date: Sun, 13 Dec 2020 18:20:52 +0100
From: Vincent Stehlé <vincent.stehle@...oste.net>
To: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Vincent Stehlé <vincent.stehle@...oste.net>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Florian Fainelli <florian.fainelli@...ecomint.eu>
Subject: [PATCH] net: korina: remove busy skb free
The ndo_start_xmit() method must not attempt to free the skb to transmit
when returning NETDEV_TX_BUSY. Fix the korina_send_packet() function
accordingly.
Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
Cc: David S. Miller <davem@...emloft.net>
Cc: Jakub Kicinski <kuba@...nel.org>
Cc: Florian Fainelli <florian.fainelli@...ecomint.eu>
---
drivers/net/ethernet/korina.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index bf48f0ded9c7d..9d84191de6824 100644
--- a/drivers/net/ethernet/korina.c
+++ b/drivers/net/ethernet/korina.c
@@ -216,7 +216,6 @@ static int korina_send_packet(struct sk_buff *skb, struct net_device *dev)
netif_stop_queue(dev);
else {
dev->stats.tx_dropped++;
- dev_kfree_skb_any(skb);
spin_unlock_irqrestore(&lp->lock, flags);
return NETDEV_TX_BUSY;
--
2.29.2
Powered by blists - more mailing lists