netdev - Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_CHQB_KX4tAFQabbuZ_iUs=QaYb6LzWC_L-4w2Rak_HjA@mail.gmail.com>
Date:   Sun, 13 Dec 2020 09:35:42 -0800
From:   Pravin Shelar <pravin.ovn@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Pravin B Shelar <pbshelar@...com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        laforge@...monks.org, Jonas Bonn <jonas@...rbonn.se>
Subject: Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

On Sat, Dec 12, 2020 at 2:11 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 11 Dec 2020 20:40:17 -0800 Pravin B Shelar wrote:
> > Following patch add support for flow based tunneling API
> > to send and recv GTP tunnel packet over tunnel metadata API.
> > This would allow this device integration with OVS or eBPF using
> > flow based tunneling APIs.
> >
> > Signed-off-by: Pravin B Shelar <pbshelar@...com>
> > ---
> > Fixed according to comments from Jonas Bonn
>
> This adds a sparse warning:
>
> drivers/net/gtp.c:218:39: warning: incorrect type in assignment (different base types)
> drivers/net/gtp.c:218:39:    expected restricted __be16 [usertype] protocol
> drivers/net/gtp.c:218:39:    got int
>
> Coding nits below.
>
Thanks, I have updated the patch.