netdev - Re: [PATCH net v2] net: openvswitch: fix TTL decrement exception action execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201214181522.6279fbaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 14 Dec 2020 18:15:22 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eelco Chaudron <echaudro@...hat.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, dev@...nvswitch.org,
        pshelar@....org, bindiyakurle@...il.com, mcroce@...ux.microsoft.com
Subject: Re: [PATCH net v2] net: openvswitch: fix TTL decrement exception
 action execution

On Mon,  7 Dec 2020 05:08:39 -0500 Eelco Chaudron wrote:
> Currently, the exception actions are not processed correctly as the wrong
> dataset is passed. This change fixes this, including the misleading
> comment.
> 
> In addition, a check was added to make sure we work on an IPv4 packet,
> and not just assume if it's not IPv6 it's IPv4.
> 
> This was all tested using OVS with patch,
> https://patchwork.ozlabs.org/project/openvswitch/list/?series=21639,
> applied and sending packets with a TTL of 1 (and 0), both with IPv4
> and IPv6.
> 
> Fixes: 69929d4c49e1 ("net: openvswitch: fix TTL decrement action netlink message format")
> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
> ---
> v2: - Undid unnessesary paramerter removal from dec_ttl_exception_handler()
>     - Updated commit message to include testing information.

Applied now, and will send to stable soon-ish.

Thanks!