netdev - Re: [PATCH net-next v2] net: dsa: mv88e6xxx: don't set non-existing learn2all bit for 6220/6250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Dec 2020 18:15:48 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rasmus Villemoes <rasmus.villemoes@...vas.dk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: don't set non-existing
 learn2all bit for 6220/6250

On Thu, 10 Dec 2020 12:06:44 +0100 Rasmus Villemoes wrote:
> The 6220 and 6250 switches do not have a learn2all bit in global1, ATU
> control register; bit 3 is reserverd.
> 
> On the switches that do have that bit, it is used to control whether
> learning frames are sent out the ports that have the message_port bit
> set. So rather than adding yet another chip method, use the existence
> of the ->port_setup_message_port method as a proxy for determining
> whether the learn2all bit exists (and should be set).
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@...vas.dk>

Applied.