netdev - Re: [PATCH net v2 1/3] ethernet: ucc_geth: set dev->max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201220080555.tgv3ndlkhzbvcpx7@skbuf>
Date:   Sun, 20 Dec 2020 10:05:55 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Rasmus Villemoes <rasmus.villemoes@...vas.dk>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Zhao Qiang <qiang.zhao@....com>, Li Yang <leoyang.li@....com>,
        Andrew Lunn <andrew@...n.ch>, linux-kernel@...r.kernel.org,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net v2 1/3] ethernet: ucc_geth: set dev->max_mtu to 1518

On Fri, Dec 18, 2020 at 11:55:36AM +0100, Rasmus Villemoes wrote:
> All the buffers and registers are already set up appropriately for an
> MTU slightly above 1500, so we just need to expose this to the
> networking stack. AFAICT, there's no need to implement .ndo_change_mtu
> when the receive buffers are always set up to support the max_mtu.
> 
> This fixes several warnings during boot on our mpc8309-board with an
> embedded mv88e6250 switch:
> 
> mv88e6085 mdio@...02120:10: nonfatal error -34 setting MTU 1500 on port 0
> ...
> mv88e6085 mdio@...02120:10: nonfatal error -34 setting MTU 1500 on port 4
> ucc_geth e0102000.ethernet eth1: error -22 setting MTU to 1504 to include DSA overhead
> 
> The last line explains what the DSA stack tries to do: achieving an MTU
> of 1500 on-the-wire requires that the master netdevice connected to
> the CPU port supports an MTU of 1500+the tagging overhead.
> 
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Cc: Vladimir Oltean <vladimir.oltean@....com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@...vas.dk>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>