lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 21 Dec 2020 05:52:16 +0000
From:   Srinivasan Raju <>
To:     Kalle Valo <>
CC:     Mostafa Afgani <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Mauro Carvalho Chehab <>,
        Rob Herring <>,
        Lukas Bulwahn <>,
        open list <>,
        "open list:NETWORKING DRIVERS (WIRELESS)" 
        "open list:NETWORKING DRIVERS" <>
Subject: RE: [PATCH] [v11] wireless: Initial driver submission for pureLiFi
 STA devices

> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here.
> Please convert the magic numbers to proper defines explaining the meaning. And for vendor commands you could even use enum to group them better in .h file somewhere.

Hi Kalle,

Thanks for reviewing the driver, We will work on the comments.


Powered by blists - more mailing lists