lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Dec 2020 07:57:17 +0200 From: Kalle Valo <kvalo@...eaurora.org> To: Srinivasan Raju <srini.raju@...elifi.com> Cc: Mostafa Afgani <mostafa.afgani@...elifi.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Rob Herring <robh@...nel.org>, Lukas Bulwahn <lukas.bulwahn@...il.com>, open list <linux-kernel@...r.kernel.org>, "open list\:NETWORKING DRIVERS \(WIRELESS\)" <linux-wireless@...r.kernel.org>, "open list\:NETWORKING DRIVERS" <netdev@...r.kernel.org> Subject: Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices Srinivasan Raju <srini.raju@...elifi.com> writes: >> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here. >> Please convert the magic numbers to proper defines explaining the >> meaning. And for vendor commands you could even use enum to group >> them better in .h file somewhere. > > Hi Kalle, > > Thanks for reviewing the driver, We will work on the comments. I haven't had time to do a throrough review yet, but I suggest fixing the stuff I commented and submitting v12. I'll then do a new review with v12. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists