lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 21 Dec 2020 15:18:59 +0900
From:   Masahiro Yamada <>
To:     Miguel Ojeda <>
Cc:     Greg KH <>,
        Guenter Roeck <>,
        "Jason A . Donenfeld" <>,
        Nathan Chancellor <>,
        Nick Desaulniers <>,
        Shuah Khan <>,
        clang-built-linux <>,
        linux-kernel <>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        Network Development <>,
Subject: Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

On Mon, Dec 14, 2020 at 12:27 AM Miguel Ojeda
<> wrote:
> On Sun, Dec 13, 2020 at 4:16 PM Greg KH <> wrote:
> >
> > Because if you get a report of something breaking for your change, you
> > need to work to resolve it, not argue about it.  Otherwise it needs to
> > be dropped/reverted.
> Nobody has argued that. In fact, I explicitly said the opposite: "So I
> think we can fix them as they come.".
> I am expecting Masahiro to follow up. It has been less than 24 hours
> since the report, on a weekend.
> Cheers,
> Miguel

Sorry for the delay.

Now I sent out the fix for lantiq_etop.c

The reason of the complication was
I was trying to merge the following patch in the same development cycle:

-Werror=return-type gives a bigger impact
because any instance of __must_check violation
results in build breakage.
So, I just dropped it from my tree (and, I will aim for 5.12).

The removal of CONFIG_ENABLE_MUST_CHECK is less impactive,
because we are still able to build with some warnings.

Tomorrow's linux-next should be OK
and, you can send my patch in this merge window.

Best Regards
Masahiro Yamada

Powered by blists - more mailing lists