netdev - Re: [PATCH v3 03/24] wfx: add Makefile/Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Dec 2020 22:19:52 +0100
From:   Jérôme Pouiller <jerome.pouiller@...abs.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-mmc@...r.kernel.org,
        Pali Rohár <pali@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v3 03/24] wfx: add Makefile/Kconfig

On Tuesday 22 December 2020 16:02:38 CET Kalle Valo wrote:
> Jerome Pouiller <Jerome.Pouiller@...abs.com> writes:
> 
> > From: Jérôme Pouiller <jerome.pouiller@...abs.com>
> >
> > Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>
> 
> [...]
> 
> > +wfx-$(CONFIG_SPI) += bus_spi.o
> > +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdio.o
> 
> Why this subst? And why only for MMC?

CONFIG_SPI is a boolean (y or empty). The both values make senses.

CONFIG_MMC is a tristate (y, m or empty). The substitution above
ensure that bus_sdio.o will included in wfx.ko if CONFIG_MMC is 'm'
("wfx-$(CONFIG_MMC) += bus_sdio.o" wouldn't make the job).

You may want to know what it happens if CONFIG_MMC=m while CONFIG_WFX=y.
This line in Kconfig prevents to compile wfx statically if MMC is a
module:
       depends on MMC || !MMC # do not allow WFX=y if MMC=m


-- 
Jérôme Pouiller