lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Dec 2020 07:16:06 +0200 From: Kalle Valo <kvalo@...eaurora.org> To: Jérôme Pouiller <jerome.pouiller@...abs.com> Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "David S . Miller" <davem@...emloft.net>, devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, linux-mmc@...r.kernel.org, Pali Rohár <pali@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org> Subject: Re: [PATCH v3 03/24] wfx: add Makefile/Kconfig Jérôme Pouiller <jerome.pouiller@...abs.com> writes: > On Tuesday 22 December 2020 16:02:38 CET Kalle Valo wrote: >> Jerome Pouiller <Jerome.Pouiller@...abs.com> writes: >> >> > From: Jérôme Pouiller <jerome.pouiller@...abs.com> >> > >> > Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com> >> >> [...] >> >> > +wfx-$(CONFIG_SPI) += bus_spi.o >> > +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdio.o >> >> Why this subst? And why only for MMC? > > CONFIG_SPI is a boolean (y or empty). The both values make senses. > > CONFIG_MMC is a tristate (y, m or empty). The substitution above > ensure that bus_sdio.o will included in wfx.ko if CONFIG_MMC is 'm' > ("wfx-$(CONFIG_MMC) += bus_sdio.o" wouldn't make the job). > > You may want to know what it happens if CONFIG_MMC=m while CONFIG_WFX=y. > This line in Kconfig prevents to compile wfx statically if MMC is a > module: > depends on MMC || !MMC # do not allow WFX=y if MMC=m Ok, thanks for explaining this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists