netdev - Re: [net,v2] net/packet: fix packet receive on L3 devices without visible hard header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJht_ENExFia=NPqYOmcF+kEFN8-YkAfUBuhzVEvPJwt0W4NZQ@mail.gmail.com>
Date:   Thu, 24 Dec 2020 02:06:44 -0800
From:   Xie He <xie.he.0141@...il.com>
To:     Eyal Birger <eyal.birger@...il.com>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Jason@...c4.com,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [net,v2] net/packet: fix packet receive on L3 devices without
 visible hard header

On Fri, Nov 20, 2020 at 10:28 PM Eyal Birger <eyal.birger@...il.com> wrote:
>
> Fix by changing af_packet RX ll visibility criteria to include the
> existence of a '.create()' header operation, which is used when creating
> a device hard header - via dev_hard_header() - by upper layers, and does
> not exist in these L3 devices.

This patch changed the RX LL visibility criteria (in the comment) to
"dev_has_header". We need to change the TX LL visibility criteria (in
the same comment), too.