netdev - Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201230191240.GX1551@shell.armlinux.org.uk>
Date:   Wed, 30 Dec 2020 19:12:40 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Marek Behún <kabel@...nel.org>
Cc:     Pali Rohár <pali@...nel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are
 detected as SFF

On Wed, Dec 30, 2020 at 06:27:07PM +0100, Marek Behún wrote:
> On Wed, 30 Dec 2020 18:06:52 +0100
> Pali Rohár <pali@...nel.org> wrote:
> 
> > 	if (!sfp->type->module_supported(&id) &&
> > 	    (memcmp(id.base.vendor_name, "UBNT            ", 16) ||
> > 	     memcmp(id.base.vendor_pn, "UF-INSTANT      ", 16)))
> 
> I would rather add a quirk member (bitfield) to the sfp structure and do
> something like this
> 
> if (!sfp->type->module_supported(&id) &&
>     !(sfp->quirks & SFP_QUIRK_BAD_PHYS_ID))
> 
> or maybe put this check into the module_supported method.

Sorry, definitely not. If you've ever looked at the SDHCI driver with
its multiple "quirks" bitfields, doing this is a recipe for creating
a very horrid hard to understand mess.

What you suggest just results in yet more complexity.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!