[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201230182707.4a8b13d0@kernel.org>
Date: Wed, 30 Dec 2020 18:27:07 +0100
From: Marek Behún <kabel@...nel.org>
To: Pali Rohár <pali@...nel.org>
Cc: Russell King - ARM Linux admin <linux@...linux.org.uk>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are
detected as SFF
On Wed, 30 Dec 2020 18:06:52 +0100
Pali Rohár <pali@...nel.org> wrote:
> if (!sfp->type->module_supported(&id) &&
> (memcmp(id.base.vendor_name, "UBNT ", 16) ||
> memcmp(id.base.vendor_pn, "UF-INSTANT ", 16)))
I would rather add a quirk member (bitfield) to the sfp structure and do
something like this
if (!sfp->type->module_supported(&id) &&
!(sfp->quirks & SFP_QUIRK_BAD_PHYS_ID))
or maybe put this check into the module_supported method.
Marek
Powered by blists - more mailing lists