lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 4 Jan 2021 21:42:37 +0800
From:   Chen-Yu Tsai <>
To:     Samuel Holland <>
Cc:     Giuseppe Cavallaro <>,
        Alexandre Torgue <>,
        Jose Abreu <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Maxime Ripard <>,
        Jernej Skrabec <>,
        Corentin Labbe <>,
        Ondrej Jirman <>,
        netdev <>,
        linux-arm-kernel <>,
        linux-kernel <>,
        linux-sunxi <>
Subject: Re: [PATCH net 1/4] net: stmmac: dwmac-sun8i: Fix probe error handling

On Sun, Jan 3, 2021 at 7:17 PM Samuel Holland <> wrote:
> stmmac_pltfr_remove does three things in one function, making it
> inapproprate for unwinding the steps in the probe function. Currently,
> a failure before the call to stmmac_dvr_probe would leak OF node
> references due to missing a call to stmmac_remove_config_dt. And an
> error in stmmac_dvr_probe would cause the driver to attempt to remove a
> netdevice that was never added. Fix these by reordering the init and
> splitting out the error handling steps.
> Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
> Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path")
> Signed-off-by: Samuel Holland <>

Reviewed-by: Chen-Yu Tsai <>

Powered by blists - more mailing lists