lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 4 Jan 2021 21:42:52 +0800
From:   Chen-Yu Tsai <>
To:     Samuel Holland <>
Cc:     Giuseppe Cavallaro <>,
        Alexandre Torgue <>,
        Jose Abreu <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Maxime Ripard <>,
        Jernej Skrabec <>,
        Corentin Labbe <>,
        Ondrej Jirman <>,
        netdev <>,
        linux-arm-kernel <>,
        linux-kernel <>,
        linux-sunxi <>
Subject: Re: [PATCH net 2/4] net: stmmac: dwmac-sun8i: Balance internal PHY
 resource references

On Sun, Jan 3, 2021 at 7:17 PM Samuel Holland <> wrote:
> While stmmac_pltfr_remove calls sun8i_dwmac_exit, the sun8i_dwmac_init
> and sun8i_dwmac_exit functions are also called by the stmmac_platform
> suspend/resume callbacks. They may be called many times during the
> device's lifetime and should not release resources used by the driver.
> Furthermore, there was no error handling in case registering the MDIO
> mux failed during probe, and the EPHY clock was never released at all.
> Fix all of these issues by moving the deinitialization code to a driver
> removal callback. Also ensure the EPHY is powered down before removal.
> Fixes: 634db83b8265 ("net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs")
> Signed-off-by: Samuel Holland <>

Reviewed-by: Chen-Yu Tsai <>

Powered by blists - more mailing lists