netdev - Re: [PATCH v2] xfrm: Fix wraparound in xfrm_policy_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210105081156.GJ3576117@gauss3.secunet.de>
Date:   Tue, 5 Jan 2021 09:11:56 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Visa Hankala <visa@...kala.org>
CC:     Florian Westphal <fw@...len.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] xfrm: Fix wraparound in xfrm_policy_addr_delta()

On Wed, Dec 30, 2020 at 04:15:53PM +0000, Visa Hankala wrote:
> Use three-way comparison for address components to avoid integer
> wraparound in the result of xfrm_policy_addr_delta(). This ensures
> that the search trees are built and traversed correctly.
> 
> Treat IPv4 and IPv6 similarly by returning 0 when prefixlen == 0.
> Prefix /0 has only one equivalence class.
> 
> Fixes: 9cf545ebd591d ("xfrm: policy: store inexact policies in a tree ordered by destination address")
> Signed-off-by: Visa Hankala <visa@...kala.org>

Applied, thanks a lot!