netdev - Re: [PATCH V2 2/2] net: ks8851: Register MDIO bus and the internal PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210104171356.3aaa125d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 4 Jan 2021 17:13:56 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH V2 2/2] net: ks8851: Register MDIO bus and the internal
 PHY

On Mon,  4 Jan 2021 13:30:17 +0100 Marek Vasut wrote:
> The KS8851 has a reduced internal PHY, which is accessible through its
> registers at offset 0xe4. The PHY is compatible with KS886x PHY present
> in Micrel switches, except the PHY ID Low/High registers are swapped.
> Register MDIO bus so this PHY can be detected and probed by phylib.
> 
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Lukas Wunner <lukas@...ner.de>
> To: netdev@...r.kernel.org

Please put this creative To: tag under --- so maintainers don't have to
stip it manually :)

There's a few warnings here:

drivers/net/ethernet/micrel/ks8851_common.c: In function ‘ks8851_mdio_read’:
drivers/net/ethernet/micrel/ks8851_common.c:1001:6: warning: unused variable ‘ret’ [-Wunused-variable]
 1001 |  int ret;
      |      ^~~

drivers/net/ethernet/micrel/ks8851.h:425: warning: Function parameter or member 'mii_bus' not described in 'ks8851_net'