netdev - Re: [PATCH net] docs: net: fix documentation on .ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210104171805.3b36c490@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 4 Jan 2021 17:18:05 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] docs: net: fix documentation on .ndo_get_stats

On Tue, 5 Jan 2021 03:03:27 +0200 Vladimir Oltean wrote:
> On Mon, Jan 04, 2021 at 09:53:09AM -0800, Jakub Kicinski wrote:
> > On Mon, 4 Jan 2021 12:42:27 +0200 Vladimir Oltean wrote:  
> > > And what happened to dev_base_lock? Did it suddenly go away?  
> >
> > I thought all callers switched to RCU. You investigated this in depth,
> > did I miss something? I'm sending this correction because I have a
> > series which adds to other sections of this file and this jumped out
> > to me as incorrect.  
> 
> Well, there's netstat_show from net/core/net-sysfs.c still. I couldn't
> figure why that lock exists, it doesn't seem to protect something in
> particular.

Ah, thanks for pointing that out, in that case I should just add RCU
to the list of locks that may be held.