| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202101062240.KXBT8Rcf-lkp@intel.com>
Date: Wed, 6 Jan 2021 22:12:39 +0800
From: kernel test robot <lkp@...el.com>
To: Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Kurt Kanzenbach <kurt@...utronix.de>,
Hauke Mehrtens <hauke@...ke-m.de>,
Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin ->
vid_end range from VLAN objects
Hi Vladimir,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Get-rid-of-the-switchdev-transactional-model/20210106-211752
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9
config: x86_64-randconfig-a012-20210106 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5c951623bc8965fa1e89660f2f5f4a2944e4981a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/74e0e1c1b435fec0a2738825a7a22abdee42322e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vladimir-Oltean/Get-rid-of-the-switchdev-transactional-model/20210106-211752
git checkout 74e0e1c1b435fec0a2738825a7a22abdee42322e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/net/dsa/mv88e6xxx/chip.c:1999:4: warning: variable 'vid' is uninitialized when used here [-Wuninitialized]
vid, untagged ? 'u' : 't');
^~~
include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
drivers/net/dsa/mv88e6xxx/chip.c:1978:9: note: initialize the variable 'vid' to silence this warning
u16 vid;
^
= 0
1 warning generated.
vim +/vid +1999 drivers/net/dsa/mv88e6xxx/chip.c
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 1969
f81ec90fe9cbf51 drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2016-05-09 1970 static void mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
80e023607982faa drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-11-30 1971 const struct switchdev_obj_port_vlan *vlan)
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 1972 {
04bed1434df256b drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2016-08-31 1973 struct mv88e6xxx_chip *chip = ds->priv;
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 1974 bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 1975 bool pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
933b4425086a81a drivers/net/dsa/mv88e6xxx/chip.c Russell King 2020-02-26 1976 bool warn;
c91498e15bf2cf2 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-07 1977 u8 member;
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 1978 u16 vid;
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 1979
e545f8657393714 drivers/net/dsa/mv88e6xxx/chip.c Tobias Waldekranz 2020-11-10 1980 if (!mv88e6xxx_max_vid(chip))
54d77b5b6ac92c7 drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2016-05-09 1981 return;
54d77b5b6ac92c7 drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2016-05-09 1982
c91498e15bf2cf2 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-07 1983 if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
7ec60d6e2c40070 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-15 1984 member = MV88E6XXX_G1_VTU_DATA_MEMBER_TAG_UNMODIFIED;
c91498e15bf2cf2 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-07 1985 else if (untagged)
7ec60d6e2c40070 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-15 1986 member = MV88E6XXX_G1_VTU_DATA_MEMBER_TAG_UNTAGGED;
c91498e15bf2cf2 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-07 1987 else
7ec60d6e2c40070 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-15 1988 member = MV88E6XXX_G1_VTU_DATA_MEMBER_TAG_TAGGED;
c91498e15bf2cf2 drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-07 1989
933b4425086a81a drivers/net/dsa/mv88e6xxx/chip.c Russell King 2020-02-26 1990 /* net/dsa/slave.c will call dsa_port_vlan_add() for the affected port
933b4425086a81a drivers/net/dsa/mv88e6xxx/chip.c Russell King 2020-02-26 1991 * and then the CPU port. Do not warn for duplicates for the CPU port.
933b4425086a81a drivers/net/dsa/mv88e6xxx/chip.c Russell King 2020-02-26 1992 */
933b4425086a81a drivers/net/dsa/mv88e6xxx/chip.c Russell King 2020-02-26 1993 warn = !dsa_is_cpu_port(ds, port) && !dsa_is_dsa_port(ds, port);
933b4425086a81a drivers/net/dsa/mv88e6xxx/chip.c Russell King 2020-02-26 1994
c9acece064e3f00 drivers/net/dsa/mv88e6xxx/chip.c Rasmus Villemoes 2019-06-20 1995 mv88e6xxx_reg_lock(chip);
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 1996
74e0e1c1b435fec drivers/net/dsa/mv88e6xxx/chip.c Vladimir Oltean 2021-01-06 1997 if (mv88e6xxx_port_vlan_join(chip, port, vlan->vid, member, warn))
774439e532bfe9d drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-08 1998 dev_err(ds->dev, "p%d: failed to add VLAN %d%c\n", port,
4d5770b39710180 drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2016-04-06 @1999 vid, untagged ? 'u' : 't');
76e398a6271285c drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-11-01 2000
74e0e1c1b435fec drivers/net/dsa/mv88e6xxx/chip.c Vladimir Oltean 2021-01-06 2001 if (pvid && mv88e6xxx_port_set_pvid(chip, port, vlan->vid))
774439e532bfe9d drivers/net/dsa/mv88e6xxx/chip.c Vivien Didelot 2017-06-08 2002 dev_err(ds->dev, "p%d: failed to set PVID %d\n", port,
74e0e1c1b435fec drivers/net/dsa/mv88e6xxx/chip.c Vladimir Oltean 2021-01-06 2003 vlan->vid);
0d3b33e60206f40 drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-08-13 2004
c9acece064e3f00 drivers/net/dsa/mv88e6xxx/chip.c Rasmus Villemoes 2019-06-20 2005 mv88e6xxx_reg_unlock(chip);
0d3b33e60206f40 drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-08-13 2006 }
0d3b33e60206f40 drivers/net/dsa/mv88e6xxx.c Vivien Didelot 2015-08-13 2007
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (38644 bytes)
Powered by blists - more mailing lists