netdev - Re: [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin -> vid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210106170821.z7m6ouapcij25y7w@skbuf>
Date:   Wed, 6 Jan 2021 19:08:21 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, kbuild-all@...ts.01.org,
        clang-built-linux@...glegroups.com, netdev@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin ->
 vid_end range from VLAN objects

On Wed, Jan 06, 2021 at 10:12:39PM +0800, kernel test robot wrote:
> static void mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
> 				    const struct switchdev_obj_port_vlan *vlan)
> {
> 	struct mv88e6xxx_chip *chip = ds->priv;
> 	bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
> 	bool pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
> 	bool warn;
> 	u8 member;
> 	u16 vid;
> 
> 	if (!mv88e6xxx_max_vid(chip))
> 		return;
> 
> 	if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
> 		member = MV88E6XXX_G1_VTU_DATA_MEMBER_TAG_UNMODIFIED;
> 	else if (untagged)
> 		member = MV88E6XXX_G1_VTU_DATA_MEMBER_TAG_UNTAGGED;
> 	else
> 		member = MV88E6XXX_G1_VTU_DATA_MEMBER_TAG_TAGGED;
> 
> 	/* net/dsa/slave.c will call dsa_port_vlan_add() for the affected port
> 	 * and then the CPU port. Do not warn for duplicates for the CPU port.
> 	 */
> 	warn = !dsa_is_cpu_port(ds, port) && !dsa_is_dsa_port(ds, port);
> 
> 	mv88e6xxx_reg_lock(chip);
> 
> 	if (mv88e6xxx_port_vlan_join(chip, port, vlan->vid, member, warn))
> 		dev_err(ds->dev, "p%d: failed to add VLAN %d%c\n", port,
> 			vid, untagged ? 'u' : 't');

s/vid/vlan->vid/

Sorry about this. I'm superseding it with a v3.