netdev - Re: [net] net: feature check mandating HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210106111710.34ab4eab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 6 Jan 2021 11:17:10 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rohit Maheshwari <rohitm@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com
Subject: Re: [net] net: feature check mandating HW_CSUM is wrong

On Wed,  6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote:
> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong.
> And it broke tls offload feature for the drivers, which are still
> using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use
> NETIF_F_CSUM_MASK instead.
> 
> Fixes: ae0b04b238e2 ("net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled")
> Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com>

Please use Tariq's suggestion.

Please learn to CC appropriate reviewers.