netdev - Re: [net] net: feature check mandating HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d94bd63-dee0-3699-8e42-193e652592fa@chelsio.com>
Date:   Wed, 13 Jan 2021 02:47:51 +0530
From:   rohit maheshwari <rohitm@...lsio.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com,
        ast@...nel.org, bjorn.topel@...el.com, daniel@...earbox.net,
        andriin@...com, tariqt@...dia.com, edumazet@...gle.com,
        xiyou.wangcong@...il.com, ap420073@...il.com, jiri@...lanox.com,
        borisp@...dia.com
Subject: Re: [net] net: feature check mandating HW_CSUM is wrong


On 07/01/21 12:47 AM, Jakub Kicinski wrote:
> On Wed,  6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote:
>> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong.
>> And it broke tls offload feature for the drivers, which are still
>> using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use
>> NETIF_F_CSUM_MASK instead.
>>
>> Fixes: ae0b04b238e2 ("net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled")
>> Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com>
> Please use Tariq's suggestion.
HW_TLS_TX feature is for both IPv4/v6. And If one device is limited to
support only IPv4 checksum offload, TLS offload should be allowed for
that too. So I think putting a check of CSUM_MASK is enough.