netdev - Re: [PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210112221632.611c8a7e@kernel.org>
Date:   Tue, 12 Jan 2021 22:16:32 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org, pavana.sharma@...i.com,
        vivien.didelot@...il.com, f.fainelli@...il.com, kuba@...nel.org,
        lkp@...el.com, davem@...emloft.net, ashkan.boldaji@...i.com,
        andrew@...n.ch, Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for
 mv88e6393x family of Marvell

On Tue, 12 Jan 2021 22:38:08 +0200
Vladimir Oltean <olteanv@...il.com> wrote:

> > +		phylink_set(mask, 10000baseT_Full);
> > +		phylink_set(mask, 10000baseCR_Full);
> > +		phylink_set(mask, 10000baseSR_Full);
> > +		phylink_set(mask, 10000baseLR_Full);
> > +		phylink_set(mask, 10000baseLRM_Full);
> > +		phylink_set(mask, 10000baseER_Full);  
> 
> Why did you remove 1000baseKR_Full from here?

I am confused now. Should 1000baseKR_Full be here? 10g-kr is 10g-r with
clause 73 autonegotiation, so they are not compatible, or are they?

Marek