[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20210105.160259.377394842851693699.davem@davemloft.net>
Date: Tue, 05 Jan 2021 16:02:59 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: zhengyongjun3@...wei.com
Cc: kuba@...nel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Markus.Elring@....de
Subject: Re: [PATCH v3 net-next] net: kcm: Replace fput with sockfd_put
From: Zheng Yongjun <zhengyongjun3@...wei.com>
Date: Wed, 30 Dec 2020 17:18:09 +0800
> The function sockfd_lookup uses fget on the value that is stored in
> the file field of the returned structure, so fput should ultimately be
> applied to this value. This can be done directly, but it seems better
> to use the specific macro sockfd_put, which does the same thing.
>
> Perform a source code refactoring by using the following semantic patch.
>
> // <smpl>
> @@
> expression s;
> @@
>
> s = sockfd_lookup(...)
> ...
> + sockfd_put(s);
> - fput(s->file);
> // </smpl>
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
Applied.
Powered by blists - more mailing lists