netdev - Re: [PATCH] neighbour: Disregard DEAD dst in neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210105.160521.1279064249478522010.davem@davemloft.net>
Date:   Tue, 05 Jan 2021 16:05:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     zhutong@...zon.com
Cc:     sashal@...nel.org, edumazet@...gle.com, vvs@...tuozzo.com,
        netdev@...r.kernel.org, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] neighbour: Disregard DEAD dst in neigh_update

From: Tong Zhu <zhutong@...zon.com>
Date: Wed, 30 Dec 2020 17:54:23 -0500

> In 4.x kernel a dst in DST_OBSOLETE_DEAD state is associated
> with loopback net_device and leads to loopback neighbour. It
> leads to an ethernet header with all zero addresses.
> 
> A very troubling case is working with mac80211 and ath9k.
> A packet with all zero source MAC address to mac80211 will
> eventually fail ieee80211_find_sta_by_ifaddr in ath9k (xmit.c).
> As result, ath9k flushes tx queue (ath_tx_complete_aggr) without
> updating baw (block ack window), damages baw logic and disables
> transmission.
> 
> Signed-off-by: Tong Zhu <zhutong@...zon.com>

Please repost with an appropriate Fixes: tag.

Thanks.