netdev - Re: [PATCH linux-next v3 1/6] vdpa_sim_net: Make mac address array static

Open Source and information security mailing list archives

Message-ID: <20210107134528.uw72mstpdorhcyvg@steredhat>
Date:   Thu, 7 Jan 2021 14:45:28 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Parav Pandit <parav@...dia.com>
Cc:     virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        elic@...dia.com, mst@...hat.com
Subject: Re: [PATCH linux-next v3 1/6] vdpa_sim_net: Make mac address array
 static

On Tue, Jan 05, 2021 at 12:31:58PM +0200, Parav Pandit wrote:
>MAC address array is used only in vdpa_sim_net.c.
>Hence, keep it static.
>
>Signed-off-by: Parav Pandit <parav@...dia.com>
>Acked-by: Jason Wang <jasowang@...hat.com>
>---
>Changelog:
>v1->v2:
> - new patch
>---
> drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
>index c10b6981fdab..f0482427186b 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
>@@ -33,7 +33,7 @@ static char *macaddr;
> module_param(macaddr, charp, 0);
> MODULE_PARM_DESC(macaddr, "Ethernet MAC address");
>
>-u8 macaddr_buf[ETH_ALEN];
>+static u8 macaddr_buf[ETH_ALEN];
>
> static struct vdpasim *vdpasim_net_dev;
>
>-- 
>2.26.2
>
>_______________________________________________
>Virtualization mailing list
>Virtualization@...ts.linux-foundation.org
>https://lists.linuxfoundation.org/mailman/listinfo/virtualization
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives