netdev - Re: [PATCH 1/3] usbnet: specify naming of usbnet_set/get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/dIq16CQ6xe+dLh@lunn.ch>
Date:   Thu, 7 Jan 2021 18:45:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, roland@...nel.org
Subject: Re: [PATCH 1/3] usbnet: specify naming of
 usbnet_set/get_link_ksettings

> -int usbnet_get_link_ksettings(struct net_device *net,
> +/* These methods are written on the assumption that the device
> + * uses MII
> + */
> +int usbnet_get_link_ksettings_mdio(struct net_device *net,
>  			      struct ethtool_link_ksettings *cmd)

Hi Oliver

I would prefer this was called usbnet_get_link_ksettings_mii, since
this is using the old mii framework, not phylib and mdio drivers.  I
believe there are some USB drivers which do use mdio drivers and
phylib, and we should try to avoid getting things confused.

	Andrew