netdev - Re: [PATCH] tcp: remove obsolete paramter sysctl_tcp_low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210107174538.GA19605@breakpoint.cc>
Date:   Thu, 7 Jan 2021 18:45:38 +0100
From:   Florian Westphal <fw@...len.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     lll <liyonglong@...natelecom.cn>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        davem@...emloft.net, fw@...len.de, soheil@...gle.com,
        ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH] tcp: remove obsolete paramter sysctl_tcp_low_latency

Jakub Kicinski <kuba@...nel.org> wrote:
> > Got it. But a question: why tcp_tw_recycle can be removed totally?
> > it is also part of uAPI
> 
> Good question, perhaps with tcp_tw_recycle we wanted to make sure users
> who depended on it notice removal, since the feature was broken by
> design? 
> 
> tcp_low_latency is an optimization, not functionality which users may
> depend on.
> 
> But I may be wrong so CCing authors.

I guess it was just a case of 'noone noticed'.
I'm not sure if anyone would notice dropping lowlatency sysctl, was just
a case of 'overly careful'.  Personally I'd rather have them gone so
'sysctl tcp.bla' shows if the feature exists/does something.