netdev - Re: [PATCH 11/18] net: iosm: encode or decode datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/eDg7jNQ6/VIY5K@lunn.ch>
Date:   Thu, 7 Jan 2021 22:56:19 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     M Chetan Kumar <m.chetan.kumar@...el.com>
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        johannes@...solutions.net, krishna.c.sudi@...el.com
Subject: Re: [PATCH 11/18] net: iosm: encode or decode datagram

> +/* Pass the DL packet to the netif layer. */
> +static int mux_net_receive(struct iosm_mux *ipc_mux, int if_id,
> +			   struct iosm_wwan *wwan, u32 offset, u8 service_class,
> +			   struct sk_buff *skb)
> +{
> +	/* for "zero copy" use clone */
> +	struct sk_buff *dest_skb = skb_clone(skb, GFP_ATOMIC);
> +
> +	if (!dest_skb)
> +		return -1;
> +
> +	skb_pull(dest_skb, offset);
> +
> +	skb_set_tail_pointer(dest_skb, dest_skb->len);
> +
> +	/* Goto the start of the Ethernet header. */
> +	skb_push(dest_skb, ETH_HLEN);
> +
> +	/* map session to vlan */
> +	__vlan_hwaccel_put_tag(dest_skb, htons(ETH_P_8021Q), if_id + 1);

Well, that explains a bit, my comments on the netdev patch. So there
is no Ethernet header on the 'wire'. This is not an Ethernet device at
all.

More in the documentation patch...

	Andrew