netdev - Re: [PATCH 17/18] net: iosm: readme file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/eJ/rl4U6edWr3i@lunn.ch>
Date:   Thu, 7 Jan 2021 23:23:58 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     M Chetan Kumar <m.chetan.kumar@...el.com>
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        johannes@...solutions.net, krishna.c.sudi@...el.com
Subject: Re: [PATCH 17/18] net: iosm: readme file

> diff --git a/drivers/net/wwan/iosm/README b/drivers/net/wwan/iosm/README

Please convert this to rst, and put it somewhere under Documentation.

> +Multiplexed IP sessions (IPS)
> +-----------------------------
> +IOSM driver allows multiplexing of several IP sessions over the single network
> +device of type wwan0. IOSM driver models such IP sessions as 802.1q VLAN
> +subdevices of the master wwanY device, mapping MBIM IP session M to VLAN ID M
> +for all values of M greater than 0.
> +
> +The userspace management application is responsible for adding new VLAN links
> +prior to establishing MBIM IP sessions where the SessionId is greater than 0.
> +These links can be added by using the normal VLAN kernel interfaces.
> +
> +For example, adding a link for a MBIM IP session with SessionId 5:
> +
> +  ip link add link wwan0 name wwan0.<name> type vlan id 5

So, this is what all the Ethernet nonsense is all about. You have a
session ID you need to somehow represent to user space. And you
decided to use VLANs. But to use VLANs, you need an Ethernet
header. So you added a bogus Ethernet header.

Is any of this VLAN stuff required by MBIM?

I suggest you throw away the pretence this is an Ethernet device. It
is not.

Linux allows you to dynamically create/destroy network
interfaces. So you want to do something like

ip link add link wwan0 name wwan42 type mbim id 42

Which will create a new mbim netdev interface using session id 42 on
top of the device which provides wwan0. I don't actually like this
last bit, but you somehow need to indicate on which MBIM transport you
want to create the new session, since you could have multiple bits of
hardware providing MBIM services.

	 Andrew