netdev - Re: [PATCH] Incorrect filename in drivers/net/phy/Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jan 2021 16:13:56 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Zhi Han <z.han@....net>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] Incorrect filename in drivers/net/phy/Makefile

On 1/6/21 2:17 AM, Zhi Han wrote:
> It should be a typing error ('-' instead of '_'), as no mdio-bus.c but
> just mdio_bus.c exists.
> 
> Just find it when inspecting these code. Tried to compile to test, but
> failed to construct an applicable .config file for that. Maybe someone
> can do that more skillfully, glad to know how.

The change was done on purpose, and your patch does not build with the
attached .config which only enables CONFIG_MDIO_DEVICE but not
CONFIG_PHYLIB, it causes the following linking failure:

  MODPOST Module.symvers
ERROR: modpost: "mdio_device_free" [drivers/net/phy/mdio_bus.ko] undefined!
ERROR: modpost: "mdio_device_reset" [drivers/net/phy/mdio_bus.ko] undefined!
ERROR: modpost: "mdio_device_create" [drivers/net/phy/mdio_bus.ko]
undefined!
ERROR: modpost: "mdio_device_register" [drivers/net/phy/mdio_bus.ko]
undefined!
ERROR: modpost: "mdio_device_bus_match" [drivers/net/phy/mdio_bus.ko]
undefined!
make[1]: *** [scripts/Makefile.modpost:111: Module.symvers] Error 1
make[1]: *** Deleting file 'Module.symvers'
make: *** [Makefile:1396: modules] Error 2
zsh: exit 2     make modules -j33

if you look at the build products you will that mdio_bus.c actually gets
built into mdio-bus.o:

 ls drivers/net/phy/mdio-bus.*
drivers/net/phy/mdio-bus.ko   drivers/net/phy/mdio-bus.mod.c
drivers/net/phy/mdio-bus.o
drivers/net/phy/mdio-bus.mod  drivers/net/phy/mdio-bus.mod.o

-- 
Florian

View attachment ".config" of type "text/plain" (93775 bytes)