netdev - Re: [PATCH] Incorrect filename in drivers/net/phy/Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Jan 2021 10:17:38 +0100
From:   Zhi Han <z.han@....net>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] Incorrect filename in drivers/net/phy/Makefile

Thanks a lot for the .config file.
I also tested it, with mdio-bus.o in the Makefile, glad to got that there is
no problem of that, although I don't know the reason/trick yet.

On Wed, Jan 06, 2021 at 04:13:56PM -0800, Florian Fainelli wrote:
> The change was done on purpose, and your patch does not build with the
> attached .config which only enables CONFIG_MDIO_DEVICE but not
> CONFIG_PHYLIB, it causes the following linking failure:
>
>   MODPOST Module.symvers
> ERROR: modpost: "mdio_device_free" [drivers/net/phy/mdio_bus.ko] undefined!
> ERROR: modpost: "mdio_device_reset" [drivers/net/phy/mdio_bus.ko] undefined!
> ERROR: modpost: "mdio_device_create" [drivers/net/phy/mdio_bus.ko]
> undefined!
> ERROR: modpost: "mdio_device_register" [drivers/net/phy/mdio_bus.ko]
> undefined!
> ERROR: modpost: "mdio_device_bus_match" [drivers/net/phy/mdio_bus.ko]
> undefined!
> make[1]: *** [scripts/Makefile.modpost:111: Module.symvers] Error 1
> make[1]: *** Deleting file 'Module.symvers'
> make: *** [Makefile:1396: modules] Error 2
> zsh: exit 2     make modules -j33
>
> if you look at the build products you will that mdio_bus.c actually gets
> built into mdio-bus.o:
>
>  ls drivers/net/phy/mdio-bus.*
> drivers/net/phy/mdio-bus.ko   drivers/net/phy/mdio-bus.mod.c
> drivers/net/phy/mdio-bus.o
> drivers/net/phy/mdio-bus.mod  drivers/net/phy/mdio-bus.mod.o
>
> --
> Florian