netdev - Re: [PATCH net] cxgb4/chtls: Fix tid stuck due to wrong update of qid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210108181249.116682c5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 Jan 2021 18:12:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ayush Sawal <ayush.sawal@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com,
        Rohit Maheshwari <rohitm@...lsio.com>
Subject: Re: [PATCH net] cxgb4/chtls: Fix tid stuck due to wrong update of
 qid

On Fri,  8 Jan 2021 23:29:14 +0530 Ayush Sawal wrote:
> +void chtls_set_quiesce_ctrl(struct sock *sk, int val)
> +{
> +	struct chtls_sock *csk;
> +	struct sk_buff *skb;
> +	unsigned int wrlen;
> +	unsigned int len;
> +	int ret;
> +
> +	wrlen = sizeof(struct cpl_set_tcb_field) + sizeof(struct ulptx_idata);
> +	wrlen = roundup(wrlen, 16);
> +
> +	skb = alloc_skb(wrlen, GFP_ATOMIC);
> +	if (!skb)
> +		return;
> +
> +	csk = rcu_dereference_sk_user_data(sk);
> +
> +	__set_tcb_field(sk, skb, 1, TF_RX_QUIESCE_V(1), 0, 0, 1);
> +	set_wr_txq(skb, CPL_PRIORITY_CONTROL, csk->port_id);
> +	ret = cxgb4_ofld_send(csk->egress_dev, skb);
> +	if (ret < 0)
> +		kfree_skb(skb);
> +}

drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_hw.c: In function ‘chtls_set_quiesce_ctrl’:
drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_hw.c:139:15: warning: unused variable ‘len’ [-Wunused-variable]
  139 |  unsigned int len;
      |               ^~~