netdev - Re: [PATCH 1/1] r8152: Add Lenovo Powered USB-C Travel Hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210108182030.77839d11@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 Jan 2021 18:20:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Schuermann <leon@...currently.online>
Cc:     oliver@...kum.org, davem@...emloft.net, hayeswang@...ltek.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] r8152: Add Lenovo Powered USB-C Travel Hub

On Fri,  8 Jan 2021 21:27:27 +0100 Leon Schuermann wrote:
> This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to
> work with the cdc_ether driver.

When you say "used to work" do you mean there was a regression where
the older kernels would work fine and newer don't? Or just "it works
most of the time"?

> However, using this driver, with the
> system suspended the device sends pause-frames as soon as the receive
> buffer fills up. This produced substantial network load, up to the
> point where some Ethernet switches stopped processing packets
> altogether.
> 
> Using the Realtek driver (r8152) fixes this issue. Pause frames are no
> longer sent while the host system is suspended.
> 
> Signed-off-by: Leon Schuermann <leon@...currently.online>
> Tested-by: Leon Schuermann <leon@...currently.online>