netdev - Re: [PATCH net-next] net: dsa: felix: the switch does not support DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b64a110c-e38e-7cc8-39d8-164cf048f62a@gmail.com>
Date:   Sat, 9 Jan 2021 17:24:39 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [PATCH net-next] net: dsa: felix: the switch does not support DMA



On 1/9/2021 12:34 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> The code that sets the DMA mask to 64 bits is bogus, it is taken from
> the enetc driver together with the rest of the PCI probing boilerplate.
> 
> Since this patch is touching the error path to delete err_dma, let's
> also change the err_alloc_felix label which was incorrect. The kzalloc
> failure does not need a kfree, but it doesn't hurt either, since kfree
> works with NULL pointers.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian