netdev - Re: [PATCH net-next] net: dsa: felix: the switch does not support DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210111161719.3e85b797@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 11 Jan 2021 16:17:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [PATCH net-next] net: dsa: felix: the switch does not support
 DMA

On Sat, 9 Jan 2021 17:24:39 -0800 Florian Fainelli wrote:
> On 1/9/2021 12:34 PM, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@....com>
> > 
> > The code that sets the DMA mask to 64 bits is bogus, it is taken from
> > the enetc driver together with the rest of the PCI probing boilerplate.
> > 
> > Since this patch is touching the error path to delete err_dma, let's
> > also change the err_alloc_felix label which was incorrect. The kzalloc
> > failure does not need a kfree, but it doesn't hurt either, since kfree
> > works with NULL pointers.
> > 
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>  
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks!