netdev - Re: [PATCH] net: phy: smsc: fix clk error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210112184007.09f6fedf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 12 Jan 2021 18:40:07 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Marco Felsch <m.felsch@...gutronix.de>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] net: phy: smsc: fix clk error handling

On Mon, 11 Jan 2021 15:17:05 +0100 Andrew Lunn wrote:
> On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote:
> > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in
> > support") added the phy clk support. The commit already checks if
> > clk_get_optional() throw an error but instead of returning the error it
> > ignores it.
> > 
> > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support")
> > Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>  
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks!